-
Notifications
You must be signed in to change notification settings - Fork 2k
chore(secretmanager): Added samples for delete secret annotation #4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(secretmanager): Added samples for delete secret annotation #4139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @durgesh-ninave-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces new Node.js code samples for the Google Cloud Secret Manager service. The primary goal is to provide clear, runnable examples demonstrating how to delete annotations from secrets, covering both the global and regional API endpoints. This enhancement improves the comprehensiveness of the existing sample set and aids developers in managing secret metadata.
Highlights
- New Secret Manager Samples: Two new Node.js samples have been added to demonstrate how to delete annotations from Google Cloud Secret Manager secrets.
- Global API Support: A sample (
deleteSecretAnnotation.js
) is provided for interacting with the global Secret Manager API to remove a specific annotation from a secret. - Regional API Support: A dedicated sample (
deleteRegionalSecretAnnotation.js
) is included to show how to delete annotations from secrets managed by the regional Secret Manager API, including proper endpoint configuration. - Test Coverage: Corresponding unit tests have been added to
secretmanager.test.js
to ensure the correctness and functionality of both the global and regional secret annotation deletion samples.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new samples for deleting secret annotations, one for global and one for regional secrets, along with corresponding tests. My review identifies a critical bug in both new sample files that would cause a crash if a secret has no annotations. I've provided suggestions to fix the bug by adding a check for oldSecret.annotations
before attempting to delete from it.
secret-manager/regional_samples/deleteRegionalSecretAnnotation.js
Outdated
Show resolved
Hide resolved
This is not a feature, please use chore for future work! Also please update the title of the pull request here |
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Created samples for Global and Regional Secret Manager API
Samples
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.