Skip to content

chore(automl): update dependencies - #4439

Draft
angelcaamal wants to merge 1 commit into
mainfrom
chore/update-automl-deps
Draft

chore(automl): update dependencies#4439
angelcaamal wants to merge 1 commit into
mainfrom
chore/update-automl-deps

Conversation

@angelcaamal

Copy link
Copy Markdown
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: automl Issues related to the AutoML API. samples Issues that are directly related to samples. labels Sep 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in automl/package.json, including @google-cloud/automl, @google-cloud/storage, c8, and chai. The reviewer noted that upgrading chai to ^6.0.0 will break the test suite because Chai v5 and above are ESM-only, whereas this project uses CommonJS. They recommended keeping chai at ^4.5.0 to maintain compatibility.

Comment thread automl/package.json
"chai": "^4.5.0",
"@google-cloud/storage": "^8.0.0",
"c8": "^12.0.0",
"chai": "^6.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading 'chai' to '^6.0.0' will break the test suite. Chai v5.0.0 and above are ESM-only, whereas this project uses CommonJS (as shown by 'module.exports' in 'automl/test/util.js'). To maintain compatibility with CommonJS 'require()', please keep 'chai' at '^4.5.0'.

Suggested change
"chai": "^6.0.0",
"chai": "^4.5.0",

@angelcaamal angelcaamal added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: automl Issues related to the AutoML API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant