chore(automl): update dependencies - #4439
Draft
angelcaamal wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies in automl/package.json, including @google-cloud/automl, @google-cloud/storage, c8, and chai. The reviewer noted that upgrading chai to ^6.0.0 will break the test suite because Chai v5 and above are ESM-only, whereas this project uses CommonJS. They recommended keeping chai at ^4.5.0 to maintain compatibility.
| "chai": "^4.5.0", | ||
| "@google-cloud/storage": "^8.0.0", | ||
| "c8": "^12.0.0", | ||
| "chai": "^6.0.0", |
Contributor
There was a problem hiding this comment.
Upgrading 'chai' to '^6.0.0' will break the test suite. Chai v5.0.0 and above are ESM-only, whereas this project uses CommonJS (as shown by 'module.exports' in 'automl/test/util.js'). To maintain compatibility with CommonJS 'require()', please keep 'chai' at '^4.5.0'.
Suggested change
| "chai": "^6.0.0", | |
| "chai": "^4.5.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.