Skip to content

chore(batch): update dependencies - #4440

Merged
angelcaamal merged 3 commits into
mainfrom
chore/update-batch-deps
Sep 3, 2026
Merged

chore(batch): update dependencies#4440
angelcaamal merged 3 commits into
mainfrom
chore/update-batch-deps

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b/556244941

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: batch Issues related to the Batch API. samples Issues that are directly related to samples. labels Sep 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in batch/package.json, including @google-cloud/batch, @google-cloud/compute, @google-cloud/resource-manager, @google-cloud/storage, and c8. Feedback was provided to update the engines.node field to >=18.0.0 to ensure compatibility with the newly upgraded packages.

Comment thread batch/package.json

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcolin
amcolin marked this pull request as ready for review September 2, 2026 21:40
@amcolin
amcolin requested review from a team as code owners September 2, 2026 21:40
@angelcaamal
angelcaamal merged commit 4ba1d26 into main Sep 3, 2026
21 of 22 checks passed
@angelcaamal
angelcaamal deleted the chore/update-batch-deps branch September 3, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: batch Issues related to the Batch API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants