Conversation
Summary of ChangesHello @spowelljr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a release preparation, primarily focused on updating the project's version number to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the version for a new release, v0.1.4, and also updates the version of the ko build tool. While the main version bump seems correct for the release, the new ko version (0.18.0) appears to be invalid as it does not correspond to an existing release. This will break the image build process. I've left a critical comment with a suggestion to fix this.
| GOARCH?=$(shell go env GOARCH) | ||
| ARCH=$(if $(findstring amd64, $(GOARCH)),x86_64,$(GOARCH)) | ||
| KO_VERSION=0.16.0 | ||
| KO_VERSION=0.18.0 |
There was a problem hiding this comment.
The KO_VERSION is being updated to 0.18.0, but this version does not appear to exist in the ko releases. This will cause the make image target to fail with a 404 error when trying to download the tool. The latest stable version seems to be 0.16.0. Please use a valid and existing version for ko.
KO_VERSION=0.16.0
There was a problem hiding this comment.
github.com/google/ko now redirects to github.com/ko-build/ko
As per the repo: