Skip to content

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Mar 17, 2025

we were comparing strings, which broke when checking "10.".

@eriknw eriknw added the bug Something isn't working label Mar 17, 2025
@eriknw eriknw merged commit 74c45cc into GraphBLAS:main Mar 17, 2025
23 checks passed
@alugowski
Copy link
Collaborator

alugowski commented Mar 17, 2025 via email

@eriknw
Copy link
Member Author

eriknw commented Mar 17, 2025

Thanks. I've also used from packaging.version import parse. Strings were easy enough to handle w/o introducing another dependency. I also considered just deleting this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants