Skip to content

fix: Path tool requires a double click to insert a new point after having dragged another point #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Annonnymmousss wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Path tool requires a double click to insert a new point after having dragged another point #3805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions editor/src/messages/tool/tool_messages/path_tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2636,6 +2636,7 @@ impl Fsm for PathToolFsmState {
responses.add(PathToolMessage::SelectedPointUpdated);
tool_data.snap_manager.cleanup(responses);
tool_data.opposite_handle_position = None;
tool_data.molding_segment = false;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you're resetting state here, it would be more robust to also reset molding_info. It's possible for molding_info to be set in mouse_down without tool_data.segment being set. In that scenario, on DragStop, the if let Some(segment) = ... block that resets molding_info would be skipped, leaving it in a stale state for the next operation. Resetting it here ensures all molding-related state is cleared.

Suggested change
tool_data.molding_segment = false;
tool_data.molding_segment = false;
tool_data.molding_info = None;


PathToolFsmState::Ready
}
Expand Down
Loading