fix undo for checkboxes

[Ayush2k02]

Bug : Keyboard shortcuts like Cmd+Z were blocked when a checkbox had focus because targetIsTextField() treated all elements as text fields.

Fix : Only treat text-like input types (text, password, email, etc.) as text fields, not checkboxes or radio buttons.

Screen.Recording.2026-03-07.at.5.32.57.PM.mov

Fixes : https://discord.com/channels/731730685944922173/731738914812854303/1479627959127117924

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a user experience issue where standard keyboard shortcuts were unexpectedly disabled when interacting with checkboxes. By refining the logic that determines if an HTML element is a text field, the change ensures that undo and other shortcuts function correctly across all input types, improving the overall responsiveness and usability of the application.

Highlights

• Bug Fix: Resolved an issue where keyboard shortcuts, such as Cmd+Z for undo, were blocked when a checkbox had focus. This occurred because the targetIsTextField function incorrectly identified all <input> elements as text fields.
• Refined Input Type Detection: Modified the targetIsTextField function to accurately distinguish between text-like input types (e.g., text, password, email) and non-text input types like checkboxes and radio buttons. Only text-like inputs are now treated as text fields for keyboard shortcut handling.

Changelog

• frontend/src/io-managers/input.ts
  • Refactored the targetIsTextField function to include explicit checks for HTMLInputElement types.
  • Introduced a list of textInputTypes to correctly identify text-like input fields.
  • Ensured that TEXTAREA and contentEditable elements are still correctly identified as text fields.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where keyboard shortcuts were blocked by focused checkboxes. The change correctly refines the targetIsTextField function to only consider text-like <input> elements as text fields. My review includes a suggestion to make this check more comprehensive by including more text-like input types and a minor performance improvement.

[cubic-dev-ai]

No issues found across 1 file

[Ayush2k02]

added some addition types apart from text like password, email etc for added measure. Can totally revert this