Skip to content

Fix #4619: Fallback to identity transform for zero-width layers in tr… #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubhtrek wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix #4619: Fallback to identity transform for zero-width layers in tr… #4624

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
542b31d
Fix #4619: Fallback to identity transform for zero-width layers in tr…
shubhtrek Sep 30, 2026
50e44d6
Fix incorrect transform cage when layer has zero width or height
shubhtrek Sep 30, 2026
4206e48
Address review feedback: extract selection bounds helper and use cons…
shubhtrek Sep 30, 2026
37b0825
Fix fallback transform and cage offsets for zero-width layers (#4619)
shubhtrek Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions editor/src/messages/tool/common_functionality/shapes/shape_utility.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use crate::messages::tool::common_functionality::shape_editor::ShapeState;
use crate::messages::tool::common_functionality::transformation_cage::BoundingBoxManager;
use crate::messages::tool::tool_messages::tool_prelude::Key;
use crate::messages::tool::utility_types::*;
use glam::{DAffine2, DMat2, DVec2};
use glam::{DAffine2, DVec2};
use graph_craft::document::NodeInput;
use graph_craft::document::value::TaggedValue;
use graphene_std::core_types::misc::format_f64;
Expand Down Expand Up @@ -252,10 +252,10 @@ pub fn transform_cage_overlays(document: &DocumentMessageHandler, tool_data: &mu
.map(|layer| document.metadata().transform_to_viewport_with_first_transform_node_if_group(layer, &document.network_interface))
.unwrap_or_default();

// Check if the matrix is not invertible
// Fallback to identity if the transform is singular (e.g. zero width or height)
let mut transform_tampered = false;
if transform.matrix2.determinant() == 0. {
transform.matrix2 += DMat2::IDENTITY * 1e-4; // TODO: Is this the cleanest way to handle this?
transform = DAffine2::IDENTITY;
transform_tampered = true;
}

Expand Down
5 changes: 2 additions & 3 deletions editor/src/messages/tool/tool_messages/select_tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ use crate::messages::tool::common_functionality::snapping::{self, SnapCandidateP
use crate::messages::tool::common_functionality::stroke_options::{StrokeOptionsUpdate, apply_stroke_option, create_stroke_options_popover_widget};
use crate::messages::tool::common_functionality::transformation_cage::*;
use crate::messages::tool::common_functionality::utility_functions::{resize_bounds, rotate_bounds, skew_bounds, text_bounding_box, transforming_transform_cage};
use glam::DMat2;
use graph_craft::document::NodeId;
use graphene_std::Color;
use graphene_std::renderer::Quad;
Expand Down Expand Up @@ -766,10 +765,10 @@ impl Fsm for SelectToolFsmState {

let mut transform = create_bounding_box_transform(document);

// Check if the matrix is not invertible
// Fallback to identity if the transform is singular (e.g. zero width or height)
let mut transform_tampered = false;
if transform.matrix2.determinant() == 0. {
transform.matrix2 += DMat2::IDENTITY * 1e-4; // TODO: Is this the cleanest way to handle this?
transform = DAffine2::IDENTITY;
transform_tampered = true;
}

Expand Down