Repository navigation
Bake rectangle and ellipse scale into the shape size - #4653
Open
Siddhartha-singh01 wants to merge 3 commits into
Open
Siddhartha-singh01 wants to merge 3 commits into
Siddhartha-singh01 wants to merge 3 commits into
Conversation
Author
|
@Keavon Sir can you check this once |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed
Reply to a comment to ask cubic a question or push back. It learns from your replies.
Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @Keavon Sir !
Before
After
few understanding about the above images
1 : Scaling a rectangle or ellipse was leaving the size alone and putting the scale on the Transform node.
2 : When the scale is finished, that scale is now written into the width and height, or the ellipse radii, and the Transform scale goes back to 1.