increase tolerance in pwmType #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid errors due to rounding imprecision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motifmatchr fails when using some motifs collections (e.g. https://doi.org/10.1093/nar/gkad1240 ) due to small rounding errors in the column sums of the PFM preventing
pwmTypefrom determining whether the motifs are PFM or PWM. While it would be possible to process the matrices to avoid this, it's actually not that trivial and unnecessary, because the problem is easily solved by increasing the tolerance inpwmType.There's also no drawback in doing so, given that it's virtually impossible that all the colSums of all PWM are by chance within 0.99-1.01.