[js] implement haxe.io.ArrayBufferView.fromBytes() #12358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haxe.io.ArrayBufferView.fromBytes()
does not exist for JS target as per docs (and source code, ofc): https://api.haxe.org/haxe/io/ArrayBufferView.htmlThis PR implements
fromBytes()
for JS target based on howfromBytes()
is implemented in/std/haxe/io/ArrayBufferView
:haxe/std/haxe/io/ArrayBufferView.hx
Line 89 in e0b355c
ArrayBufferViewData
for JS target isjs.lib.ArrayBufferView
which is a helper representing JSTypedArray
.Uint8Array
is one of the native JS typed arrays, and HaxeUInt8ArrayData
has been used to implementfromBytes
for JS in similar way it is in the source link above.UInt8ArrayData
for JS target does not unify withArrayBufferViewImpl
from the source link above, however the implementation in this post seems to work on JS target in my tests.