[hl] Fix abstract Array with inline dyn length segfault #12380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See test for repro.
hl-check gives
Check failure at fun@3750 @D - Register 1(hl.types.ArrayObj) should be hl.types.ArrayDyn and not hl.types.ArrayObjon compilation, and the program access violation on runtime when accessing.length.This ArrayObj tries to access ArrayDyn seems to come from
inlineand abstract(Array), where haxe compiler generate the following dump