Fix version types #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version readings in the hhea and vhea tables are currently not appropriate.
https://docs.microsoft.com/en-us/typography/opentype/spec/hhea
https://docs.microsoft.com/en-us/typography/opentype/spec/vhea
According to these, there are two versions in hhea, major and minor. They are both uint16, so the current single int32
versiondid not cause any problems.In vhea, however, there is one
version, and it seems to beuint32, notuint16. Currently, this causes a two-byte gap, andnumberOfMetricswill always return zero. And it's also causing problems with reading the vmtx table.