Skip to content

fix: FIT-248: Adapt scrollbars to dark mode #7985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 21, 2025

Conversation

carly-bartel
Copy link
Contributor

@carly-bartel carly-bartel commented Jul 15, 2025

Reason for change

Scrollbars on several pages in Dark Mode were appearing white, which was a regression as per Ricardo Cabral. This was due to some elements missing the styled-scrollbar mixin, preventing them from adopting the correct dark mode styling.

Screenshots

Before
Screenshot 2025-07-15 at 1 34 46 PM
Screenshot 2025-07-15 at 1 35 13 PM
Screenshot 2025-07-15 at 1 35 25 PM

After
Screenshot 2025-07-15 at 1 38 08 PM
Screenshot 2025-07-15 at 1 38 30 PM
Screenshot 2025-07-15 at 1 38 42 PM

Testing

The fix was verified by following the steps to reproduce the original bug:

  1. As OWNER, log in to https://ls-release.appx.humansignal.com/
  2. Click on Create project button
  3. Observe that Create Project modal pops up
  4. Navigate to data import tab
  5. Import provided data: TSSyncData.json
  6. Navigate to Labeling Interface tab
  7. Click on Custom template option
  8. Add provided config: AudioVideoTSSyncConfig.txt
  9. Click on Save button
  10. Observe that you’re at Data Manager
  11. Click on imported task
  12. Observe that you’re at Quick View
  13. Confirm that several scrollbars are now adapted to Dark Mode.
  14. Navigate to Settings > Labeling Interface page
  15. Confirm that the horizontal scrollbar is now adapted to Dark Mode.
  16. Navigate to Organization page
  17. Confirm that the scrollbar on the right side is now adapted to Dark Mode.

Reviewer notes

The changes primarily involve removing the 'styled-scrollbar' mixin and applying them globally in the tailwind.css file

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit b676250
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/687e6e7cb745b70008d7d0e4

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit b676250
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/687e6e7c433c4c0008269dfc
😎 Deploy Preview https://deploy-preview-7985--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit b676250
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/687e6e7cbae3cb00087de3ff

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit b676250
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/687e6e7cba4906000833b8fc
😎 Deploy Preview https://deploy-preview-7985--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.89%. Comparing base (b7fc7f7) to head (b676250).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7985      +/-   ##
===========================================
+ Coverage    63.68%   65.89%   +2.21%     
===========================================
  Files          715      504     -211     
  Lines        50292    33376   -16916     
  Branches      8589     8589              
===========================================
- Hits         32027    21993   -10034     
+ Misses       18262    11380    -6882     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 59.49% <ø> (?)
lsf-integration 55.60% <ø> (ø)
lsf-unit 9.40% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carly-bartel carly-bartel changed the title Fb fit 248/scrollbars white fix: Scrollbars are white on several pages in Dark mode Jul 15, 2025
@carly-bartel carly-bartel changed the title fix: Scrollbars are white on several pages in Dark mode fix: FIT-248: Scrollbars are white on several pages in Dark mode Jul 15, 2025
@carly-bartel carly-bartel changed the title fix: FIT-248: Scrollbars are white on several pages in Dark mode fix: FIT-248: Adapt scrollbars to dark mode Jul 15, 2025
@ricardoantoniocm ricardoantoniocm marked this pull request as ready for review July 16, 2025 12:01
@yyassi-heartex
Copy link
Contributor

yyassi-heartex commented Jul 16, 2025

/fmt

Workflow run

Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this mixin to a dedicated file and import it? That would make it universal and easily accessible in any other places

@carly-bartel carly-bartel requested a review from hlomzik July 17, 2025 15:25
@carly-bartel
Copy link
Contributor Author

Can we move this mixin to a dedicated file and import it? That would make it universal and easily accessible in any other places

@hlomzik i removed all of the mixins and just applied the scrollbar style globally in the tailwind.css file

@robot-ci-heartex robot-ci-heartex merged commit bdd7bbe into develop Jul 21, 2025
46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-248/scrollbars-white branch July 21, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants