-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: FIT-248: Adapt scrollbars to dark mode #7985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7985 +/- ##
===========================================
+ Coverage 63.68% 65.89% +2.21%
===========================================
Files 715 504 -211
Lines 50292 33376 -16916
Branches 8589 8589
===========================================
- Hits 32027 21993 -10034
+ Misses 18262 11380 -6882
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…crolling on labeling interface
/fmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this mixin to a dedicated file and import it? That would make it universal and easily accessible in any other places
@hlomzik i removed all of the mixins and just applied the scrollbar style globally in the tailwind.css file |
Reason for change
Scrollbars on several pages in Dark Mode were appearing white, which was a regression as per Ricardo Cabral. This was due to some elements missing the
styled-scrollbar
mixin, preventing them from adopting the correct dark mode styling.Screenshots
Before



After



Testing
The fix was verified by following the steps to reproduce the original bug:
https://ls-release.appx.humansignal.com/
TSSyncData.json
AudioVideoTSSyncConfig.txt
Reviewer notes
The changes primarily involve removing the 'styled-scrollbar' mixin and applying them globally in the tailwind.css file