fix: FIT-792: Task action menu sometimes loads only reduced number of action items #8679
+267
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8679 +/- ##
===========================================
- Coverage 67.07% 8.34% -58.73%
===========================================
Files 790 478 -312
Lines 60675 33264 -27411
Branches 10310 9034 -1276
===========================================
- Hits 40697 2777 -37920
- Misses 19975 30484 +10509
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/git merge
|
|
/fmt |
robot-ci-heartex
requested review from
hlomzik and
nick-skriabin
as code owners
…-fit-792/action-menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modernizes how available actions are fetched and managed in the DataManager UI by introducing a new React hook,
useActions, powered by TanStack Query. The change replaces MobX-based flows with a hook-based approach, improving caching, loading states, and developer experience. The legacy MobXfetchActionsflow is now deprecated, and actions are fetched on-demand when needed, reducing unnecessary API calls and aligning with best practices for React data fetching.Key changes:
1. Actions fetching refactor and TanStack Query integration
useActionshook (useActions.ts) that fetches actions from the DataManager API using TanStack Query, supporting caching, loading/error states, and per-project cache scoping.ActionsButtoncomponent to use theuseActionshook instead of MobX flows, simplifying logic and improving UI responsiveness and reliability. [1] [2] [3]2. Documentation and migration guidance
useActions, usage patterns, migration steps from MobX, and best practices for TanStack Query integration.3. MobX flow deprecation and cleanup
fetchActionsflow as deprecated inAppStore.js, retaining it only for backward compatibility and logging errors for failed fetches.fetchActionsin favor of on-demand fetching via the new hook, preventing duplicate API calls and unnecessary data fetching.