fix: preserve base path for Heidi tips - #9916
Open
motodriver wants to merge 1 commit into
Open
Conversation
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change
The Heidi Tips request uses a root-relative
/heidi-tipsURL. When Label Studio is hosted below a path prefix, the browser sends the request to the domain root instead of the configured application path.Solution
absoluteURLhelperTesting
bun test --dom apps/labelstudio/src/components/HeidiTips/utils.test.tsdocument.cookiewarninggit diff --checkpassedAcceptance criteria
/heidi-tips/./basepath, Heidi Tips requests/basepath/heidi-tips/.Risk
Low. The change uses the existing application URL helper and only affects the endpoint URL construction.
Fixes the Heidi Tips sub-path case in #9652.