fix: remove dead io_storages/filesystem.py module - #9923
Open
pranaysb wants to merge 1 commit into
Open
Conversation
The module imports from a non-existent .base submodule (from .base import BaseForm, BaseStorage, CloudStorage), so importing it raises ModuleNotFoundError. No file in the codebase imports this module or references any of the classes it defines, and the BaseForm/BaseStorage/ CloudStorage classes it depends on no longer exist anywhere in the repo. Fixes HumanSignal#9815
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for label-studio-playground canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
label_studio/io_storages/filesystem.pydoesfrom .base import BaseForm, BaseStorage, CloudStorage, but nobasemodule exists inio_storages/(the nearest isbase_models.py, which does not define these names). Importing this module raisesModuleNotFoundError.JSONStorage,DirJSONsStorage,TasksJSONStorage,ExternalTasksJSONStorage,AnnotationsDirStorage). It is dead legacy code left over from an older storage implementation that predates the current model-based storage system inio_storages/base_models.py.BaseForm/BaseStorage/CloudStoragebase classes it depends on no longer exist anywhere in the codebase, fixing the import isn't a real option without reintroducing removed functionality — deleting the file is the minimal, safe fix.Fixes #9815
Test plan
grep -rn "io_storages.filesystem\|from \.filesystem\|import filesystem" label_studio/— zero importers before and afterJSONStorage,DirJSONsStorage,TasksJSONStorage,ExternalTasksJSONStorage,AnnotationsDirStorage) are referenced elsewhere in the codebase