Skip to content

fix(identity) iam_id as compute in profile of TP template #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(identity) iam_id as compute in profile of TP template #6237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ibm/service/iamidentity/resource_ibm_iam_trusted_profile_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func ResourceIBMTrustedProfileTemplate() *schema.Resource {
Schema: map[string]*schema.Schema{
"iam_id": {
Type: schema.TypeString,
Required: true,
Computed: true,
Description: "IAM ID of the identity.",
},
"identifier": {
Expand Down Expand Up @@ -789,7 +789,9 @@ func resourceIBMTrustedProfileTemplateProfileClaimRuleConditionsToMap(model *iam

func resourceIBMTrustedProfileTemplateProfileIdentityResponseToMap(model *iamidentityv1.ProfileIdentityResponse) (map[string]interface{}, error) {
modelMap := make(map[string]interface{})
modelMap["iam_id"] = model.IamID
if model.IamID != nil {
modelMap["iam_id"] = model.IamID
}
modelMap["identifier"] = model.Identifier
modelMap["type"] = model.Type
if model.Accounts != nil {
Expand Down
1 change: 0 additions & 1 deletion ibm/service/iamidentity/resource_ibm_iam_trusted_profile_template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ func testAccCheckIBMTrustedProfileTemplateConfig(name string, description string
}
}
identities {
iam_id = "crn-crn:v1:staging:public:iam-identity::a/684e0f537b4548eb8d2c9593881a6b03:::"
identifier = "crn:v1:staging:public:iam-identity::a/684e0f537b4548eb8d2c9593881a6b03:::"
type = "crn"
}
Expand Down
12 changes: 3 additions & 9 deletions .../r/trusted_profile_template.html.markdown → ...am_trusted_profile_template.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
layout: "ibm"
page_title: "IBM : ibm_trusted_profile_template"
page_title: "IBM : ibm_iam_trusted_profile_template"
description: |-
Manages IAM trusted profile templates
Manages iam_trusted_profile_template
subcategory: "Identity & Access Management (IAM)"
---

# ibm_trusted_profile_template
# ibm_iam_trusted_profile_template

Create, update, commit, and delete trusted profile templates with this resource.

Expand All @@ -31,7 +31,6 @@ resource "ibm_iam_trusted_profile_template" "trusted_profile_template_instance"
}
}
identities {
iam_id = "IBMid-123456789"
identifier = "IBMid-123456789"
type = "user"
accounts = ["3213asv21s3d2vsd6bv54sfb321dfb"]
Expand All @@ -50,7 +49,6 @@ resource "ibm_iam_trusted_profile_template" "trusted_profile_template_instance"
name = "Profile from Template"
description = "description of profile from template"
identities {
iam_id = "iam-ServiceId-abcd83bd-e218-48af-8073-c0c1b3980001"
identifier = "ServiceId-abcd83bd-e218-48af-8073-c0c1b3980001"
type = "serviceid"
}
Expand All @@ -77,7 +75,6 @@ resource "ibm_iam_trusted_profile_template" "trusted_profile_template_instance"
name = "Profile from Template"
description = "description of profile from template"
identities {
iam_id = format("crn-%s", var.instance_crn)
identifier = var.instance_crn
type = "crn"
}
Expand All @@ -100,7 +97,6 @@ resource "ibm_iam_trusted_profile_template" "trusted_profile_template_instance"
name = "Profile from Template"
description = "description of profile from template"
identities {
iam_id = "iam-ServiceId-abcd83bd-e218-48af-8073-c0c1b3980001"
identifier = "ServiceId-abcd83bd-e218-48af-8073-c0c1b3980001"
type = "serviceid"
}
Expand All @@ -124,7 +120,6 @@ resource "ibm_iam_trusted_profile_template" "trusted_profile_template_v2" {
name = "Profile from Template"
description = "description of profile from template"
identities {
iam_id = "iam-ServiceId-abcd83bd-e218-48af-8073-c0c1b3980001"
identifier = "ServiceId-abcd83bd-e218-48af-8073-c0c1b3980001"
type = "serviceid"
}
Expand Down Expand Up @@ -163,7 +158,6 @@ Nested schema for **profile**:
Nested schema for **identities**:
* `accounts` - (Optional, List) Only valid for the type user. Accounts from which a user can assume the trusted profile.
* `description` - (Optional, String) Description of the identity that can assume the trusted profile. This is optional field for all the types of identities. When this field is not set for the identity type 'serviceid' then the description of the service id is used. Description is recommended for the identity type 'crn' E.g. 'Instance 1234 of IBM Cloud Service project'.
* `iam_id` - (Required, String) IAM ID of the identity.
* `identifier` - (Required, String) Identifier of the identity that can assume the trusted profiles. This can be a user identifier (IAM id), serviceid or crn. Internally it uses account id of the service id for the identifier 'serviceid' and for the identifier 'crn' it uses account id contained in the CRN.
* `type` - (Required, String) Type of the identity.
* Constraints: Allowable values are: `user`, `serviceid`, `crn`.
Expand Down
Loading