Skip to content

changes for snapshot creation in CG #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hemalathagajendran wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

changes for snapshot creation in CG #1417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f068154
changes for snapshot creation in CG
hemalathagajendran Dec 2, 2025
eaf747c
Added changes
hemalathagajendran Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion driver/csiplugin/controllerserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3434,6 +3434,7 @@ func (cs *ScaleControllerServer) CreateSnapshot(newctx context.Context, req *csi
}
snapName, createNewSnap, err := cs.CheckIfNewSnapshotIsRequired(ctx, conn, filesystemName, filesetName, filesetResp.FilesetName, snapName, volumeIDMembers.StorageClassType, snapWindowInt, snapExist)
if err != nil {

return nil, err
}
if createNewSnap {
Expand Down Expand Up @@ -3519,8 +3520,16 @@ func (cs *ScaleControllerServer) CheckIfNewSnapshotIsRequired(ctx context.Contex
return snapName, createNewSnap, err
}
if cgSnapName != "" {
usable, err := cs.isExistingSnapUseableForVol(ctx, conn, filesystemName, filesetName, fsetName, cgSnapName)
usable, _ := cs.isExistingSnapUseableForVol(ctx, conn, filesystemName, filesetName, fsetName, cgSnapName)
if !usable {
pathDir := fmt.Sprintf("%s/.snapshots/%s", filesetName, cgSnapName)
_, err := conn.StatDirectory(ctx, filesystemName, pathDir)
if err != nil {
if strings.Contains(err.Error(), "EFSSG0264C") ||
strings.Contains(err.Error(), "does not exist") { // directory does not exist
return snapName, createNewSnap, nil
}
}
return snapName, createNewSnap, err
}
createNewSnap = false
Expand Down