-
Notifications
You must be signed in to change notification settings - Fork 5
Containerize agentic AI example application #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
manju956
commented
Jul 30, 2025
- Contains separate Containerfiles for HMC server and Client
- logic to parse HMC related configurations and pass to HMC server and client
- Modifications in HMC server to run on different port
- Modifications in HMC client to accept OPENAI_BASE_URL and MCP_SERVER_URL at runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a README under examples/hmc-agent, explaining the expected configs need to be set by the user.
Also instructions on how to build
Add a README inside app also what's what and steps to build server and agent containers.
examples/hmc-agent/app/agent.py
Outdated
@@ -54,7 +55,10 @@ async def interactive_chat(self): | |||
|
|||
async def main(): | |||
try: | |||
client = MCPClient() | |||
model = os.getenv("OLLAMA_MODEL") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not OLLAMA_MODEL right?
extract it from llm.conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is model param from llmArgs, will rename it
examples/hmc-agent/hmc_config.sh
Outdated
var_to_add=MCP_SERVER_URL=$(jq -r '.mcpServerURL' /etc/pim/pim_config.json) | ||
sed -i "/^MCP_SERVER_URL=.*/d" /etc/pim/hmc.conf && echo "$var_to_add" >> /etc/pim/hmc.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you expecting this so that user need to set it directly via ip instead of localhost:8003/sse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am expecting user to provide MCP server URL with PIM partition's IP eg: http://9.114.98.3:8003/sse
Addressed documentation. ptal |
examples/hmc-agent/README.md
Outdated
|
||
## Configuration | ||
|
||
Since vLLM AI image can be used as a base for many LLM inferencing applications like chatbot, entity extraction and many more. Below provided configurations tune the vLLM engine as per the AI use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since vLLM AI image can be used as a base for many LLM inferencing applications like chatbot, entity extraction and many more. Below provided configurations tune the vLLM engine as per the AI use case. | |
Since vLLM AI image can be used as a base for many LLM inferencing applications like chatbot, entity extraction and many more. Below provided configurations tune the vLLM engine as per the HMC Agent AI use case. |
How much is the final image size Mac? |
It is around 1.6 GB |
Cool, how about after installing pyarrow and streamlit? |
Streamlit installation was falling yesterday, will take the updated Container file and try again |
@manju956 please squash the commits before merging |
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>