Adds gitlab container registry settings to installation files #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
@pranjayyelkotwar, please try the secure production installation and see if it works. Thanks.
| - "443:443" | ||
| volumes: | ||
| - "/var/run/docker.sock:/var/run/docker.sock:ro" | ||
| - "/etc/letsencrypt:/etc/letsencrypt:ro" |
There was a problem hiding this comment.
letsencrypt does not work for localhost. That is why we are using mkcert in secure localhost. Please use secure production installation to integrate the container registry.
| - "--entrypoints.web.http.redirections.entrypoint.permanent=true" | ||
| - "--providers.file.directory=/etc/traefik/dynamic" | ||
| - "--providers.file.watch=true" | ||
| - "--certificatesresolvers.manual.acme.tlschallenge=true" |
There was a problem hiding this comment.
why do we need these three?
| labels: | ||
| - "traefik.enable=true" | ||
| - "traefik.http.routers.client.rule=PathPrefix(`/`)" | ||
| - "traefik.http.routers.client.rule=Host(`release.dtaas-digitaltwin.com`)" |
There was a problem hiding this comment.
Please use compose.server.secure.yml file for installation.
prasadtalasila
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
compose.gitlab.ymlto enable gitlab container registry. The changes tocompose.local.secure.ymlare invalid and need to be reverted.