-
Notifications
You must be signed in to change notification settings - Fork 31
WIP: ♻️ Use projects_nodes
table instead of projects.workbench
(🗃️)
#8141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP: ♻️ Use projects_nodes
table instead of projects.workbench
(🗃️)
#8141
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8141 +/- ##
==========================================
- Coverage 87.78% 84.09% -3.70%
==========================================
Files 1838 1940 +102
Lines 71369 75416 +4047
Branches 1311 1311
==========================================
+ Hits 62653 63418 +765
- Misses 8321 11603 +3282
Partials 395 395
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
… github.com:giancarloromeo/osparc-simcore into pr/giancarloromeo/8141
… github.com:giancarloromeo/osparc-simcore into is5646/use-project-nodes-table-instead-of-workbench
… github.com:giancarloromeo/osparc-simcore into pr/giancarloromeo/8141
projects_nodes
table instead of projects.workbench
(🗃️)projects_nodes
table instead of projects.workbench
(🗃️)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will review when ready
|
What do these changes do?
This PR removes the workbench column from the projects database table, completing the migration from storing node data in the projects table to the dedicated projects_nodes table. This is a major database schema change that required extensive refactoring throughout the codebase.
Removal of the workbench column from the projects table definition and migration of all node data to projects_nodes table
Replacement of direct workbench access with queries to projects_nodes table using a subquery pattern
Updates to all test fixtures and utilities to use the new projects_nodes based approach
Related issue/s
projects
table still referenced #8201How to test
Dev-ops