Skip to content

✨ [Frontend] User profile details #8282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 2, 2025
Merged

✨ [Frontend] User profile details #8282

merged 14 commits into from
Sep 2, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 1, 2025 •
edited
Loading

What do these changes do?

Requested by @calys during the Voyager RM 29.08.

This PR introduces a user profile details feature that's only accessible to Product Owners. It creates a modal dialog displaying user information including username, full name, email, user ID, and group ID, alongside a user thumbnail.

This might be extended with extra information and exposed to other roles once the backend supports it.

UserDetails

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 1, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 1, 2025
@odeimaiz odeimaiz added this to the Narsil milestone Sep 1, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 1, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for c93a9c7.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@odeimaiz odeimaiz requested a review from Copilot September 1, 2025 13:12
@odeimaiz odeimaiz marked this pull request as ready for review September 1, 2025 13:13
Copilot
Copilot AI reviewed Sep 1, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a user profile details feature that's only accessible to Product Owners. It creates a modal dialog displaying user information including username, full name, email, user ID, and group ID, alongside a user thumbnail. The changes also refactor thumbnail handling to use a new dedicated UserThumbnail component.

Key changes:

  • New UserDetails dialog component for displaying comprehensive user information
  • UserThumbnail component that opens user details on click for Product Owners
  • Refactored thumbnail creation to support dynamic sizing
  • Updated UI text for release notes

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
osparc/user/UserDetails.js New modal dialog component displaying user profile information in a grid layout
osparc/ui/basic/UserThumbnail.js New clickable user thumbnail component that opens UserDetails for Product Owners
osparc/data/model/User.js Added createThumbnail method and refactored thumbnail initialization
osparc/conversation/MessageUI.js Updated to use new UserThumbnail component instead of Utils.createThumbnail
osparc/store/Support.js Changed release notes menu text from "Release Notes" to "What's new in"

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Sep 1, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Sep 1, 2025

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 1, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

pcrespov
pcrespov reviewed Sep 1, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was wondering that we also call "SupportID" to the code produced by OECs :-)

On that line of thought. perhaps it would be good to have a link/button to open the support chat when you have these OEC-like errors

@odeimaiz
Copy link
Member Author

odeimaiz commented Sep 1, 2025

i was wondering that we also call "SupportID" to the code produced by OECs :-)

On that line of thought. perhaps it would be good to have a link/button to open the support chat when you have these OEC-like errors

That "SupportId" in the header is only shown to the Supporters, but we could call it "ConversationId"....

In the OEC popup, we could have a link to the support 👍

Now, what about the PR?

sanderegg
sanderegg reviewed Sep 1, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GitHK
GitHK approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also some copy buttons would be great.
Also if there is a project that was shared with you, I would also include the project_id, which could help during suppot requests

@odeimaiz
Copy link
Member Author

odeimaiz commented Sep 2, 2025 •
edited
Loading

i was wondering that we also call "SupportID" to the code produced by OECs :-)

On that line of thought. perhaps it would be good to have a link/button to open the support chat when you have these OEC-like errors

This will go here #8288

@odeimaiz odeimaiz requested a review from pcrespov September 2, 2025 09:57
@odeimaiz odeimaiz enabled auto-merge (squash) September 2, 2025 10:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bisgaard-itis
bisgaard-itis approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks

pcrespov
pcrespov approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some extra suggestions:

The user info/profile is nice.

  • I would group all possible user UNIQUE identifiers, i.e.user name, user id, primary user group id
  • Email as a link
  • Button to copy to clipboard each entry or all (this i would systematically do in all "info"-like windows)

@odeimaiz odeimaiz merged commit 8768457 into ITISFoundation:master Sep 2, 2025
108 of 110 checks passed
This was referenced Sep 2, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

Copilot code review Copilot Copilot left review comments

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@calys calys Awaiting requested review from calys

Assignees

@odeimaiz odeimaiz

Labels
🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Cheops
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @GitHK @pcrespov @sanderegg @matusdrobuliak66 @bisgaard-itis