✨♻️Autoscaling/dask nthreads2 🚨 🚨 🚨

[sanderegg]

What do these changes do?

Second trial at refactoring autoscaling like in #8423
Re-revert #8557

The problem was due to an infortunate refactoring in services/autoscaling/src/simcore_service_autoscaling/models.py/.
Added a note and an issue for refactoring that problem:
#8559

Related issue/s

• fixes Autoscaling: in non-billable systems the chosen machine type does not take in account the removed resources as the dask-sidecar does #6320

How to test

Dev-ops

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 5339eac.

✅ Passed Jobs With Interesting Signals

Pipeline	Job	Signal	Health on master	Retries	🔍 CI Insights	📄 Logs
CI	integration-tests	Base branch is broken, but retries were needed. Could be early signs of flakiness 👀		1	View	View
	system-tests	Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀		2	View	View
	unit-tests	Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀		1	View	View

[codecov]

Codecov Report

❌ Patch coverage is 96.31336% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.42%. Comparing base (1a5c20b) to head (5339eac).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8558      +/-   ##
==========================================
+ Coverage   87.03%   87.42%   +0.39%     
==========================================
  Files        1890     1608     -282     
  Lines       74091    67028    -7063     
  Branches     1350      763     -587     
==========================================
- Hits        64483    58598    -5885     
+ Misses       9204     8177    -1027     
+ Partials      404      253     -151     

Flag	Coverage Δ
integrationtests	63.92% <28.57%> (-9.50%)	⬇️
unittests	85.90% <96.31%> (+<0.01%)	⬆️

Components	Coverage Δ
pkg_aws_library	94.98% <100.00%> (+1.37%)	⬆️
pkg_celery_library	∅ <ø> (∅)
pkg_dask_task_models_library	79.00% <76.92%> (-0.34%)	⬇️
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	71.00% <62.50%> (-0.01%)	⬇️
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	85.01% <ø> (+0.05%)	⬆️
agent	93.10% <ø> (ø)
api_server	91.35% <ø> (∅)
autoscaling	95.83% <99.20%> (+0.83%)	⬆️
catalog	92.06% <ø> (ø)
clusters_keeper	99.14% <ø> (ø)
dask_sidecar	92.38% <ø> (ø)
datcore_adapter	97.95% <ø> (ø)
director	75.81% <ø> (+0.08%)	⬆️
director_v2	90.97% <100.00%> (+0.07%)	⬆️
dynamic_scheduler	96.66% <ø> (ø)
dynamic_sidecar	90.44% <ø> (ø)
efs_guardian	89.83% <ø> (ø)
invitations	90.90% <ø> (ø)
payments	92.80% <ø> (ø)
resource_usage_tracker	91.74% <ø> (-0.59%)	⬇️
storage	86.56% <ø> (-0.09%)	⬇️
webclient	∅ <ø> (∅)
webserver	87.06% <66.66%> (+0.76%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5c20b...5339eac. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pcrespov]

thx!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud