-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add Docker support #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexanderNZ
wants to merge
1
commit into
IcePanel:main
Choose a base branch
from
AlexanderNZ:pr/docker-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Dependencies | ||
| node_modules/ | ||
|
|
||
| # Build output (will be built in container) | ||
| dist/ | ||
|
|
||
| # Git | ||
| .git/ | ||
| .gitignore | ||
|
|
||
| # Environment files (secrets should be passed at runtime) | ||
| .env | ||
| .env.* | ||
| !.env.example | ||
|
|
||
| # IDE and editor files | ||
| .vscode/ | ||
| .idea/ | ||
| *.swp | ||
| *.swo | ||
| .DS_Store | ||
|
|
||
| # Logs | ||
| *.log | ||
| npm-debug.log* | ||
| pnpm-debug.log* | ||
|
|
||
| # Test files | ||
| *.test.ts | ||
| *.spec.ts | ||
| __tests__/ | ||
| coverage/ | ||
|
|
||
| # Documentation (not needed in image) | ||
| *.md | ||
| !README.md | ||
|
|
||
| # Misc | ||
| .aider* | ||
| *.tgz | ||
| CODEOWNERS | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # IcePanel MCP Server Dockerfile | ||
| # Multi-stage build for minimal production image | ||
|
|
||
| # Stage 1: Build | ||
| FROM node:22-alpine AS builder | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # Copy package files | ||
| COPY package.json pnpm-lock.yaml ./ | ||
|
|
||
| # Install pnpm and dependencies | ||
| RUN corepack enable && corepack prepare pnpm@latest --activate | ||
| RUN pnpm install | ||
|
|
||
| # Copy source code | ||
| COPY tsconfig.json ./ | ||
| COPY src/ ./src/ | ||
| COPY bin/ ./bin/ | ||
|
|
||
| # Build TypeScript | ||
| RUN pnpm run build | ||
|
|
||
| # Stage 2: Production | ||
| FROM node:22-alpine AS production | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # Copy package files | ||
| COPY package.json pnpm-lock.yaml ./ | ||
|
|
||
| # Install pnpm and production dependencies only | ||
| RUN corepack enable && corepack prepare pnpm@latest --activate | ||
| RUN pnpm install --prod | ||
|
|
||
| # Copy built files from builder stage | ||
| COPY --from=builder /app/dist ./dist | ||
| COPY --from=builder /app/bin ./bin | ||
|
|
||
| # Environment variables (to be provided at runtime) | ||
| # API_KEY - Your IcePanel API key (required) | ||
| # ORGANIZATION_ID - Your IcePanel organization ID (required) | ||
| # ICEPANEL_API_BASE_URL - Optional API base URL override | ||
|
|
||
| # Run the MCP server via stdio transport | ||
| ENTRYPOINT ["node", "bin/icepanel-mcp-server.js"] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary indirection copying bin/ through builder stage
Low Severity
The
bin/directory is copied to the builder stage on line 19, then copied from builder to production on line 38. However,bin/contains only static JavaScript files that aren't modified during the TypeScript build (onlysrc/is compiled todist/). Thebin/directory could be copied directly to the production stage from the build context, eliminating the unnecessary routing through the builder.Additional Locations (1)
Dockerfile#L37-L38