Skip to content

fix(action-strip): Fix pinning actions not showing correct label on hovering. #16082 #16084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 25, 2025
Merged

fix(action-strip): Fix pinning actions not showing correct label on hovering. #16082 #16084

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1325138
fix(action-strip): Fix pinning actions not showing correct label on h…
skrustev Jul 28, 2025
1f77712
fix(action-strip): Fix pinning icons being added with metadata.
skrustev Aug 19, 2025
31d29e4
Revert "fix(action-strip): Fix pinning actions not showing correct la…
skrustev Aug 19, 2025
726f5f6
Merge branch 'master' into skrastev/fix-16082-master
Lipata Aug 21, 2025
b96b517
Merge branch 'master' into skrastev/fix-16082-master
kdinev Sep 17, 2025
ac2f2d7
Merge branch 'master' into skrastev/fix-16082-master
dkamburov Sep 24, 2025
ddfd02e
Merge branch 'master' into skrastev/fix-16082-master
kdinev Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,10 @@ export class IgxFilteringService implements OnDestroy {
public registerSVGIcons(): void {
const editorIcons = editor as any[];
editorIcons.forEach(icon => {
this.iconService.addSvgIconFromText(icon.name, icon.value, 'imx-icons');
this.iconService.addSvgIconFromText(icon.name, icon.value, 'imx-icons', true);
});
this.iconService.addSvgIconFromText(pinLeft.name, pinLeft.value, 'imx-icons');
this.iconService.addSvgIconFromText(unpinLeft.name, unpinLeft.value, 'imx-icons');
this.iconService.addSvgIconFromText(pinLeft.name, pinLeft.value, 'imx-icons', true);
this.iconService.addSvgIconFromText(unpinLeft.name, unpinLeft.value, 'imx-icons', true);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ export class IgxGridToolbarComponent implements OnDestroy {
private iconService: IgxIconService,
private element: ElementRef<HTMLElement>
) {
this.iconService.addSvgIconFromText(pinLeft.name, pinLeft.value, 'imx-icons');
this.iconService.addSvgIconFromText(unpinLeft.name, unpinLeft.value, 'imx-icons');
this.iconService.addSvgIconFromText(pinLeft.name, pinLeft.value, 'imx-icons', true);
this.iconService.addSvgIconFromText(unpinLeft.name, unpinLeft.value, 'imx-icons', true);
}

/** @hidden @internal */
Expand Down
Loading