navigation: Unset the narrative text when the icon changes #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark9064
added
enhancement
|
Build size and comparison to main:
|
mmind
force-pushed
the
navigation-narrative
branch
from
9298ad3 to
3c4952c
Compare
Navigation narrative commonly comes only at specific intervals and at least OSMand does update the direction icon and countdown-distance way earlier. This can lead to situations when the old narrative is displayed to a mismatched direction icon. So after the icon changes, assume the narrative is not applicable anymore. The flag-update in the code also happens before possibly updating the narrative, so if a new narrative text is send within the same update, this will happen just normally.
mmind
force-pushed
the
navigation-narrative
branch
from
3c4952c to
7bb292d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation narrative commonly comes only at specific intervals and at least OSMand does update the direction icon and countdown-distance way earlier.
This can lead to situations when the old narrative is displayed to a mismatched direction icon.
So after the icon changes, assume the narrative is not applicable anymore.
The flag-update in the code also happens before possibly updating the narrative, so if a new narrative text is send within the same update, this will happen just normally.