Add a codemod for dataclass changes in 3.11 #1257
Conversation
facebook-github-bot
added
the
CLA Signed
|
@itamaro no, not at all. If you wanna take a stab at it, feel free to commandeer this PR :) |
don't have the time right now, and it's useful enough to merge as is! |
Python 3.11 changed the field default mutability check for dataclasses to only allow defaults which are hashable. This codemod helps with the migration by changing all default values that aren't obviously hashable to use `default_factory` instead. Note: it's impossible to accurately determine if a particular expression produces a hashable value in a codemod, so the codemod significantly over-approximates what's unhashable.
|
Hi @zsol! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Add a codemod for dataclass changes in 3.11
Python 3.11 changed the field default mutability check for dataclasses to only allow defaults which are hashable.
This codemod helps with the migration by changing all default values that aren't obviously hashable to use
default_factoryinstead.Note: it's impossible to accurately determine if a particular expression produces a hashable value in a codemod, so the codemod significantly over-approximates what's unhashable.