Update `dpnp.isclose` with scalar-specific SYCL kernels #2540

vlad-perevezentsev · 2025-07-25T16:16:08Z

This PR suggests updating dpnp.isclose() function adding a scalar-specific SYCL kernels for both contiguous and stride cases to improve performance when rtol and atol are scalars.
Also extends and updates tests for dpnp.isclose()

The new kernel improves performance by up to 10x compared to the previous implementation when rtol and atol are scalars (tested on PVC).

CPU results:

GPU results:

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?

github-actions · 2025-07-25T16:37:44Z

View rendered docs @ https://intelpython.github.io/dpnp/pull/2540/index.html

github-actions · 2025-07-25T16:50:39Z

Array API standard conformance tests for dpnp=0.19.0dev2=py313h509198e_40 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp

dpnp/backend/kernels/elementwise_functions/isclose.hpp

dpnp/dpnp_iface_logic.py

… rtol/atol

coveralls · 2025-07-30T13:10:01Z

coverage: 71.79% (-0.3%) from 72.108%
when pulling 248e066 on update_isclose
into 30918e4 on master.

dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp

dpnp/backend/kernels/elementwise_functions/isclose.hpp

dpnp/dpnp_iface_logic.py

dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp

antonwolfy · 2025-08-05T13:47:52Z

dpnp/dpnp_iface_logic.py

+    try:
+        a, b = dpnp.broadcast_arrays(a, b)
+    except ValueError:
+        raise ValueError(


What is the reason reissuing the same exception ?
Can we just call a, b = dpnp.broadcast_arrays(a, b) without any try/except?

antonwolfy · 2025-08-05T13:48:17Z

dpnp/dpnp_iface_logic.py

+    out_dtype = dpnp.bool
+    output = dpnp.empty(
+        a.shape, dtype=out_dtype, sycl_queue=exec_q, usm_type=usm_type


Suggested change

out_dtype = dpnp.bool

output = dpnp.empty(

a.shape, dtype=out_dtype, sycl_queue=exec_q, usm_type=usm_type

output = dpnp.empty(

a.shape, dtype=dpnp.bool, sycl_queue=exec_q, usm_type=usm_type

antonwolfy · 2025-08-05T13:50:02Z

dpnp/dpnp_iface_logic.py

+        b.get_array(),
+        rtol,
+        atol,
+        equal_nan,


It seems there is no check above that equal_nan is bool scalar. Should we add that?

antonwolfy · 2025-08-05T13:51:11Z

dpnp/dpnp_iface_logic.py

@@ -870,6 +940,10 @@ def isclose(a, b, rtol=1e-05, atol=1e-08, equal_nan=False):
        rtol, atol, scalar_type=True, all_scalars=True
    )

+    # Use own SYCL kernel for scalar rtol/atol
+    if dpnp.isscalar(rtol) and dpnp.isscalar(atol):


in above docstrings there is missing mentioning that equal_nan is optional

antonwolfy · 2025-08-05T13:52:05Z

dpnp/tests/test_logic.py

+        "atol", [1e-8, dpnp.array(1e-8), dpnp.full((10,), 1e-8)]
+    )
+    def test_isclose(self, dtype, rtol, atol):
+        a = numpy.random.rand(10)


Would it be better to use generate_random_numpy_array which has seeding?

antonwolfy · 2025-08-05T13:52:35Z

dpnp/tests/test_logic.py

-    a = numpy.random.rand(10)
-    b = a + numpy.random.rand(10) * 1e-8
+class TestIsClose:
+    @pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))


Do we need to exclude None from list of dtypes?

antonwolfy · 2025-08-05T14:01:47Z

dpnp/tests/test_logic.py

-    assert_allclose(dpnp_res, np_res)
+        np_res = numpy.isclose(a, b, rtol=1e-5, atol=1e-8)
+        dpnp_res = dpnp.isclose(dpnp_a, dpnp_b, rtol=rtol, atol=atol)
+        assert_allclose(dpnp_res, np_res)


the result is always a bool array:

Suggested change

assert_allclose(dpnp_res, np_res)

assert_equal(dpnp_res, np_res)

the same below

vlad-perevezentsev added 17 commits June 18, 2025 06:46

Init commit

31f05a0

Init IsCloseContigFunctor with explicit T1, T2, resTy

745a28c

Handle scalar inputs and broadcast shapes in def isclose()

295a848

Use three_offsets_indexer in IsCloseFunctor

1088fa7

Add strided implementation of isclose()

1151fc3

Update strided implementation and rename functions

5f90ab5

Refactor isclose scalar dispatch to use dispatch vectors

29bcb34

Simplify isclose function pointer declarations

fe1f519

Restructure isclose.cpp

38d8401

Use common validation utilities

821065f

Fix argument order in IsCloseStridedScalarFunctor constructor

4df1136

Cleanup isclose.cpp

d80eab7

Add support rtol/atol as complex to match NumPy

8873008

Expand and update tests for dpnp.isclose()

86c99cd

Merge master into update_isclose

e3ca497

Update copyright year

2874520

Update changelog

68b3878

vlad-perevezentsev self-assigned this Jul 25, 2025

vlad-perevezentsev requested review from antonwolfy, AlexanderKalistratov, vtavana and ndgrigorian as code owners July 25, 2025 16:16

antonwolfy reviewed Jul 29, 2025

View reviewed changes

antonwolfy added this to the 0.19.0 release milestone Jul 29, 2025

vlad-perevezentsev added 4 commits July 30, 2025 03:22

Fix incorrect complex isclose logic and add proper overload

ddd2ec0

Make immutable variables const

819262d

Extend check_no_overlap to handle same logical tensors

8691551

Fix rtol/atol conversion getting real part of complex to match NumPy

15685e8

vlad-perevezentsev added 4 commits July 30, 2025 04:47

Apply remarks

725891c

Refactor isclose() by using separate _isclose_scalar_tol() for scalar…

c7c7011

… rtol/atol

Merge master into update_isclose

665f043

Update TestIsClose

c5da321

antonwolfy reviewed Jul 30, 2025

View reviewed changes

dpnp/dpnp_iface_logic.py Show resolved Hide resolved

antonwolfy reviewed Jul 30, 2025

View reviewed changes

dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp Show resolved Hide resolved

antonwolfy reviewed Jul 30, 2025

View reviewed changes

dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp Outdated Show resolved Hide resolved

vlad-perevezentsev added 11 commits July 31, 2025 04:14

Add with_requires(numpy

c1112c3

Remove unused includes

35fc367

Use dpctl tensor include to use experimental SYCL namespace for complex

4b552eb

Return inclusion pybind11/stl.h

f68249c

Use static_assert to isclose

394727f

Remove offsets passing for contig impl

c27596f

Use dpnp.broadcast_arrays() instead of dpnp.broadcast_shapes()

a71f1bb

Improve code coverage

2d22e62

Merge remote-tracking branch 'origin/master' into update_isclose

248e066

Remove impossible used special case for contig data

0822f98

Merge master into update_isclose

9af0901

antonwolfy reviewed Aug 5, 2025

View reviewed changes

	assert_allclose(dpnp_res, np_res)
	assert_equal(dpnp_res, np_res)

Update dpnp.isclose with scalar-specific SYCL kernels #2540

Are you sure you want to change the base?

Update dpnp.isclose with scalar-specific SYCL kernels #2540

Uh oh!

Conversation

vlad-perevezentsev commented Jul 25, 2025

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

github-actions bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonwolfy Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

antonwolfy Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

antonwolfy Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

antonwolfy Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

antonwolfy Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antonwolfy Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antonwolfy Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

antonwolfy Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Update `dpnp.isclose` with scalar-specific SYCL kernels #2540

Update `dpnp.isclose` with scalar-specific SYCL kernels #2540

github-actions bot commented Jul 25, 2025 •

edited

Loading

coveralls commented Jul 30, 2025 •

edited

Loading

antonwolfy Aug 5, 2025 •

edited

Loading

antonwolfy Aug 5, 2025 •

edited

Loading