Skip to content

Allow size value where each element is castable to Py_ssize_t #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 9, 2025
Merged

Allow size value where each element is castable to Py_ssize_t #2578

merged 7 commits into from
Sep 9, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 8, 2025 •
edited
Loading

The PR updates object to tuple logic to align with NumPy and CuPy and to accept any size value passed to random function where each element is castable to Py_ssize_t type. Previously only size value with integer elements was acceptable.

The PR closes #2564.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Sep 8, 2025
@antonwolfy antonwolfy self-assigned this Sep 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_31 ran successfully.
Passed: 1226
Failed: 1
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Sep 8, 2025 •
edited
Loading

Coverage Status

coverage: 71.563% (+0.01%) from 71.551%
when pulling a5cd35b on resolve-gh-2564
into 956db4c on master.

vlad-perevezentsev
vlad-perevezentsev reviewed Sep 8, 2025
View reviewed changes
vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @antonwolfy !

@antonwolfy antonwolfy merged commit 266faed into master Sep 9, 2025
69 of 71 checks passed
@antonwolfy antonwolfy deleted the resolve-gh-2564 branch September 9, 2025 11:07
github-actions bot added a commit that referenced this pull request Sep 9, 2025
@github-actions
Allow size value where each element is castable to Py_ssize_t (#2578
6c6685c 
)

The PR updates `object to tuple` logic to align with NumPy and CuPy and
to accept any `size` value passed to random function where each element
is castable to `Py_ssize_t` type. Previously only `size` value with
integer elements was acceptable.

The PR closes #2564. 266faed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.

dpnp.random.random issue with argument types
3 participants
@antonwolfy @coveralls @vlad-perevezentsev