Add implementation of dpnp.ndarray.tobytes method
#2656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_42 ran successfully. |
Collaborator
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
| Examples | ||
| -------- | ||
| >>> import numpy as np | ||
| >>> import dpnp as np |
Contributor
There was a problem hiding this comment.
Please update the same line in def poisson and def rayleigh as well
Contributor
Author
There was a problem hiding this comment.
It was intended to keep that as it is now. The functions needs to be fully reworked and the whole docstrings have to be updated there, not only examples.
vlad-perevezentsev
approved these changes
Nov 10, 2025
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Nov 10, 2025
The PR adds implementation of `dpnp.ndarray.tobytes` method converting the array to `numpy.ndarray` and calling `.tobytes(...)` for the result. aec0164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds implementation of
dpnp.ndarray.tobytesmethod converting the array tonumpy.ndarrayand calling.tobytes(...)for the result.