Deprecate positional out argument in dpnp.minimum and dpnp.maximum
#2659
+72
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2659/index.html |
antonwolfy
reviewed
Nov 10, 2025
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_56 ran successfully. |
vlad-perevezentsev
force-pushed
the
deprecated_out_arg
branch
from
e7f1c9d to
75f6a27
Compare
antonwolfy
reviewed
Nov 11, 2025
| assert dpnp.allclose(result, expected) | ||
|
|
||
|
|
||
| @testing.with_requires("numpy>=2.4") |
Contributor
There was a problem hiding this comment.
need to mute warning in the tests:
dpnp/tests/test_binary_ufuncs.py: 10 warnings
/localdisk/work/antonvol/miniforge3/envs/dpnp_dev/lib/python3.13/unittest/case.py:238: DeprecationWarning: Passing more than 2 positional arguments is deprecated. If you meant to use the third argument as an output, use the `out` keyword argument instead.
callable_obj(*args, **kwargs)
dpnp/tests/test_sycl_queue.py: 18 warnings
/localdisk/work/antonvol/code/dpnp/dpnp/tests/test_sycl_queue.py:1040: DeprecationWarning: `dpnp.asfarray` is deprecated, and will be removed in a future release. Please use `dpnp.asarray` with an appropriate dtype instead.
dpnp_data = getattr(dpnp, func)(data, device=device)
dpnp/tests/test_usm_type.py::test_array_copy[device-device-asfarray]
dpnp/tests/test_usm_type.py::test_array_copy[device-shared-asfarray]
dpnp/tests/test_usm_type.py::test_array_copy[device-host-asfarray]
dpnp/tests/test_usm_type.py::test_array_copy[shared-device-asfarray]
dpnp/tests/test_usm_type.py::test_array_copy[shared-shared-asfarray]
dpnp/tests/test_usm_type.py::test_array_copy[shared-host-asfarray]
dpnp/tests/test_usm_type.py::test_array_copy[host-device-asfarray]
dpnp/tests/test_usm_type.py::test_array_copy[host-shared-asfarray]
dpnp/tests/test_usm_type.py::test_array_copy[host-host-asfarray]
/localdisk/work/antonvol/code/dpnp/dpnp/tests/test_usm_type.py:299: DeprecationWarning: `dpnp.asfarray` is deprecated, and will be removed in a future release. Please use `dpnp.asarray` with an appropriate dtype instead.
y = getattr(dpnp, func)(x, usm_type=usm_type_y)
Contributor
There was a problem hiding this comment.
still need to mute:
dpnp/tests/test_binary_ufuncs.py: 10 warnings
/localdisk/work/antonvol/miniforge3/envs/dpnp_dev/lib/python3.13/unittest/case.py:238: DeprecationWarning: Passing more than 2 positional arguments is deprecated. If you meant to use the third argument as an output, use the `out` keyword argument instead.
callable_obj(*args, **kwargs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests raising a
DeprecationWarningwhenoutis passed positionally todpnp.minimumanddpnp.maximum.Align with NumPy 2.4