Skip to content
This repository was archived by the owner on Dec 20, 2023. It is now read-only.

Move to Material 3, Dependency and version updates #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SebastianAigner
Copy link
Member

No description provided.

Dependency and version updates
@SebastianAigner SebastianAigner requested a review from pjBooms May 12, 2023 20:11
@SebastianAigner
Copy link
Member Author

Annoyance: M3 text fields are @ExperimentalMaterial3Api. That would be confusing to new users, I think?

@dima-avdeev-jb
Copy link
Contributor

Annoyance: M3 text fields are @ExperimentalMaterial3Api. That would be confusing to new users, I think?

Yes, I think for now it is still better to use material2. There are still a lot of material3 functions that should be annotated with ExperimentalMaterial3Api in Compose Multiplatform 1.4.0.

@SebastianAigner
Copy link
Member Author

Waiting for androidx.compose.material3:material3:1.1.0 to be in Compose Multiplatform (as per internal https://jetbrains.slack.com/archives/C015PT6ALK1/p1683958041731039?thread_ts=1683923364.886949&cid=C015PT6ALK1)

@maicol07
Copy link

Hi,
material3 1.1.0 has been released! Will this be merged?
https://developer.android.com/jetpack/androidx/releases/compose-material3#1.1.0

@@ -21,5 +21,5 @@ android.minSdk=24

#Versions
kotlin.version=1.8.20
agp.version=7.4.2
agp.version=8.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be updated to agp.version=8.0.2

Copy link

@milksense milksense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinnZou
Copy link

@dima-avdeev-jb Hi, I apologize for posting an unrelated issue here. I couldn't find a suitable place to submit it. The main purpose of my message is to share my compose-multiplatform-library-template library, which offers a template for the Compose Multiplatform library project.

The main goal of this library is to simplify the development of a Library for Compose Multiplatform. Initially, I used the Application Template to create my WebView Library. However, I realized that it may not be suitable for a Library project. As a result, I created this library to address the encountered issues and improve its functionality.

It is built on top of this template but made some changes to fit the needs of a library project. Basically, it contains the following changes:

  • Add a lib module for the shared library code.
  • Move the androidApp and iosApp modules to the samples folder.
  • Apply the org.jetbrains.dokka plugin to generate documentation for the library code.
  • Set up a GitHub Action to publish the documentation to GitHub Pages.
  • Apply the com.vanniktech.maven.publish plugin to streamline the process of publishing a library.

I also created another library that add support for Desktop target. https://github.com/KevinnZou/compose-multiplatform-library-template

I would appreciate it if you could have a review on it and give me some suggestions.

@dima-avdeev-jb
Copy link
Contributor

@KevinnZou Thanks! I checked, looks great. I like your approach to add library publication with sample of usage this library. It is very usefull!

Feel tree to post such interesting topics to Kotlin Slack in channel #compose or #compose-desktop

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants