Fix contract in AngularJS plugin. #899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract for `processTupleArgument` is meant to say that the function will not return a non-null value if `nullIfNotFound = false`. However, the old contract said the opposite: that if the function returned a non-null value, then `nullIfNotFound = false`, which is not true (if the value is found, `nullIfNotFound` plays no role). At the moment, the compiler cannot use either contract meaningfully so the difference is immaterial. If https://youtrack.jetbrains.com/issue/KT-63378/Support-or-prohibit-contracts-that-use-Boolean-parameters-on-the-right-of-an-implies is resolved and support for this is added, the new contract will allow the call-sites that pass `nullIfNotFound = false` to perform a smart cast to `List<R>` instead of having to use `!!`.
|
Sorry for not getting back earlier, but this PR has slipped our attention. I've checked the mentioned issue and apparently in Kotlin 2.3 there is going to be support for I will leave this PR open till Angular plugin codebase is moved to Kotlin 2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract for
processTupleArgumentis meant to say that the function will not return a non-null value ifnullIfNotFound = false. However, the old contract said the opposite: that if the function returned a non-null value, thennullIfNotFound = false, which is not true (if the value is found,nullIfNotFoundplays no role).At the moment, the compiler cannot use either contract meaningfully so the difference is immaterial. If https://youtrack.jetbrains.com/issue/KT-63378/Support-or-prohibit-contracts-that-use-Boolean-parameters-on-the-right-of-an-implies is resolved and support for this is added, the new contract will allow the call-sites that pass
nullIfNotFound = falseto perform a smart cast toList<R>instead of having to use!!.