Skip to content

Allow N-dimensional arrays in sort rules #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow N-dimensional arrays in sort rules #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b856287
Allow N-dimensional arrays in sorting rules
pxl-th Aug 30, 2023
5f4814b
Restrict Nd tests to 1.9
pxl-th Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rulesets/Base/sort.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ function rrule(::typeof(partialsort), xs::AbstractVector, k::Union{Integer,Ordin
return ys, partialsort_pullback
end

function frule((_, ẋs), ::typeof(sort), xs::AbstractVector; kw...)
function frule((_, ẋs), ::typeof(sort), xs::AbstractArray; kw...)
inds = sortperm(xs; kw...)
return xs[inds], ẋs[inds]
end

function rrule(::typeof(sort), xs::AbstractVector; kwargs...)
function rrule(::typeof(sort), xs::AbstractArray; kwargs...)
inds = sortperm(xs; kwargs...)
ys = xs[inds]

Expand Down
12 changes: 12 additions & 0 deletions test/rulesets/Base/sort.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,18 @@
# rev
test_rrule(sort, a)
test_rrule(sort, a; fkwargs=(;rev=true))

if VERSION ≥ v"1.9"
a = rand(5, 4)
for dims in (1, 2)
# fwd
test_frule(sort, a; fkwargs=(;dims))
test_frule(sort, a; fkwargs=(;dims, rev=true))
# rev
test_rrule(sort, a; fkwargs=(;dims))
test_rrule(sort, a; fkwargs=(;dims, rev=true))
end
end
end
@testset "partialsort" begin
a = rand(10)
Expand Down