Add option for backends to run vectorization passes #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
requested changes
Sep 9, 2025
There was a problem hiding this comment.
See the TODO below the code you changed:
TODO: Make this not dependent on
uses_julia_runtime(likely CPU), but it's own control
The native back-end should then declare can_vectorize = true
Also, doesn't this need to be set for AMDGPU, which seems like the motivation for this change?
|
Should CUDA also not set this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 75.40% 75.73% +0.33%
==========================================
Files 24 24
Lines 3521 3524 +3
==========================================
+ Hits 2655 2669 +14
+ Misses 866 855 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this and a change to AMDGPU, for loops in the code can vectorize