Define DotProduct as Binary Op #194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theogf
changed the title
This was referenced Oct 19, 2021
|
Closed in favor of #386 or another approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #98, i started to refactor the way Distances is used:
DotProductis now anAbstractBinaryOpBinaryOpis the union ofAbstractBinaryOpandPreMetricAbstractBinaryOpsuch as :evaluate(::AbstractBinaryOp)(a,b)pairwise,pairwise!and_pairwise!result_typepairwisefor vectors since it is now supported natively by Distances.jlDistances.jlforAbstractBinaryOp, i.e. we have nowpairwise[!]forAbstractMatrixandAbstractVectorsfollowing the same principles thanDistances.jl