Skip to content

Conversation

pddshk
Copy link

@pddshk pddshk commented Oct 21, 2024

Namely:

  • is_distance_regular
  • is_strongly_regular
  • intersection_array
  • global_parameters

Wikipedia reference

NetworkX reference

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for this contribution and sorry for the delay!
I think these are useful functions, but before I review in detail, could you maybe:

  • choose more specific names for global_parameters and perhaps intersection_array (perhaps prefix them with distance_regular)
  • test all the functions you introduce, including on cases where they return false
  • whenever possible, avoid math in the docstrings (it doesn't display well in the REPL), replace the double backticks with single backticks and leverage unicode instead

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants