Skip to content

Use iszero(?) instead of ?==zero(...) for warning when adding edge, for Symbolics Num compatibility #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use iszero(?) instead of ?==zero(...) for warning when adding edge, for Symbolics Num compatibility #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/simpleweighteddigraph.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,9 @@ Graphs.inneighbors(g::SimpleWeightedDiGraph, v::Integer) = g.weights[v, :].nzind
# add_edge! will overwrite weights.
function Graphs.add_edge!(g::SimpleWeightedDiGraph, e::SimpleWeightedGraphEdge)
T = eltype(g)
U = weighttype(g)
s_, d_, w = Tuple(e)

if w == zero(U)
if iszero(w)
@warn "Note: adding edges with a zero weight to this graph type has no effect." maxlog =
1 _id = :swd_add_edge_zero
return false
Expand Down
3 changes: 1 addition & 2 deletions src/simpleweightedgraph.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,9 @@ Graphs.inneighbors(g::SimpleWeightedGraph, x...) = outneighbors(g, x...)
# add_edge! will overwrite weights.
function Graphs.add_edge!(g::SimpleWeightedGraph, e::SimpleWeightedGraphEdge)
T = eltype(g)
U = weighttype(g)
s_, d_, w = Tuple(e)

if w == zero(U)
if iszero(w)
@warn "Note: adding edges with a zero weight to this graph type has no effect." maxlog =
1 _id = :swg_add_edge_zero
return false
Expand Down
Loading