Skip to content

fix padding error - #132

Open
hhaensel wants to merge 3 commits into
JuliaIO:masterfrom
hhaensel:hh-tuple
Open

hhaensel wants to merge 3 commits into
JuliaIO:masterfrom
hhaensel:hh-tuple

Conversation

@hhaensel

Copy link
Copy Markdown

This PR addresses #121
Not sure, what a good way of warning could be. Currently I spit out a warning every time, which is probably not the best idea for the final version.
Mikmoore's comments on discourse were very helpful for finding this solution.

@hhaensel

hhaensel commented Mar 22, 2025 •

Copy link
Copy Markdown
Author

I also tried unsafe_wrapping for types containing arrays, like Dates.CompoundPeriod, which cannot be written with this solution.
Interestingly, that worked, although I thought it should not. Will investigate deeper. But that's nothing for this PR.

EDIT: I think I misinterpreted an error message and couldn't reproduce, so please ignore this post.

@hhaensel

Copy link
Copy Markdown
Author

@DhairyaLGandhi not sure whom to ask for a review, could you help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant