-
-
Notifications
You must be signed in to change notification settings - Fork 28
Add low-level wrappers for BLAS and LAPACK #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The |
Hello @ViralBShah, I autogenerated them from a custom Julia script that directly parse the Fortran files in Reference-LAPACK. Note that that I will visit @langou next month during ten days and we plan to work on that. |
642d561
to
b71c688
Compare
There are a few lapack calls with one argument that need fixing too. Perhaps the generator script can be updated? It would be nice to have a In theory, we can use Clang.jl to automatically generate the entire API for CBLAS. |
@ViralBShah I can upload my Fortran parser of F77 but I need to clean it a little bit. What would be great to have the "buffer" version of the LAPACK routines with LAPACKE. |
3ad63b5
to
3db0f47
Compare
The reason to do cblas would be then to wrap that into the low level Julia interface and have Linear Algebra use that and delete the fortran bindings altogether. The LAPACKE style overhaul can easily be done in a new external package. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1403 +/- ##
===========================================
- Coverage 93.88% 78.19% -15.70%
===========================================
Files 34 36 +2
Lines 15891 20215 +4324
===========================================
+ Hits 14920 15807 +887
- Misses 971 4408 +3437 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We'll also need to see the impact this has on system image size. |
All wrappers are removed in |
The tests are all passing now. I will check the system size impact. Hopefully it isn’t much. Given that it is all working now, perhaps not much incentive to change to cblas now, but this puts us in a really good position to do it whenever we need to. |
Superseed #1386
cc @ViralBShah @langou