Skip to content

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 7, 2025

The issymmetric condition for numbers currently checks that x == x. The only condition under which this won't hold is if isnan(x). We may therefore replace this check by isnan, which is inferred at compile time for most Number types.

Similarly, ishermitian(x) = x == conj(x) may be replaced by isreal(x) && issymmetric(x).

Copy link

codecov bot commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.89%. Comparing base (1f55352) to head (40d5a4f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1435   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          34       34           
  Lines       15900    15900           
=======================================
  Hits        14929    14929           
  Misses        971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant