-
-
Notifications
You must be signed in to change notification settings - Fork 35
Specialize norm-related functions for Diagonal #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
+ Coverage 93.89% 93.90% +0.01%
==========================================
Files 34 34
Lines 15926 15934 +8
==========================================
+ Hits 14953 14963 +10
+ Misses 973 971 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevengj
reviewed
Sep 23, 2025
stevengj
reviewed
Sep 23, 2025
stevengj
reviewed
Sep 23, 2025
Co-authored-by: Steven G. Johnson <[email protected]>
44ebe95 to
e74bdb4
Compare
GianmarcoCuppari
pushed a commit
to GianmarcoCuppari/LinearAlgebra.jl
that referenced
this pull request
Nov 2, 2025
For banded matrices such as `Diagonal`, we may skip the non-stored elements in computing the norm, as the contribution of these would be zero. This improves performance. On master ```julia julia> D1 = Diagonal(rand(1000)); julia> D2 = Diagonal(rand(1000)); julia> @Btime norm($D1); 2.668 ms (0 allocations: 0 bytes) julia> @Btime isapprox($D1, $D2); 8.007 ms (3 allocations: 7.88 KiB) ``` vs this PR ```julia julia> @Btime norm($D1); 247.196 ns (0 allocations: 0 bytes) julia> @Btime isapprox($D1, $D2); 1.696 μs (0 allocations: 0 bytes) ``` --------- Co-authored-by: Steven G. Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For banded matrices such as
Diagonal, we may skip the non-stored elements in computing the norm, as the contribution of these would be zero.This improves performance.
On master
vs this PR