Skip to content

Add explicit-imports pre-commit hook #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add explicit-imports pre-commit hook #4329

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2dcbe44
add ExplicitImports pre-commit code check
KristofferC Jul 16, 2025
d3ea753
use recommended hook approach
IanButterworth Jul 19, 2025
d06c52d
Merge branch 'master' into kc/explicit_check
IanButterworth Jul 19, 2025
b84e4d7
work around script not activating ExplicitImports project
IanButterworth Jul 19, 2025
54a9d5e
Update .pre-commit-config.yaml
IanButterworth Jul 19, 2025
090fef9
add explicit-imports pre-commit hook
ericphanson Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,9 @@ repos:
- id: runic
additional_dependencies:
- '[email protected]' # Keep version in sync with .github/workflows/Check.yml
- repo: https://github.com/JuliaTesting/ExplicitImports.jl
rev: 1fcbe989a493e9795b5fcdb56a534f30264cf182
hooks:
- id: explicit-imports
language_version: '1.12'
args: ['--checklist', 'no_implicit_imports,all_qualified_accesses_via_owners,no_self_qualified_accesses']
Loading