add a lock when mutating PkgInfo
#4394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we cache the registries, multiple threads can mutate the same pkginfo simultaneously
|
I could've sworn I did this already... |
|
Oh, I guess #4341 was incomplete |
|
LGTM my only thought is that the other PR put the lock inside the init function. We should probably follow the same pattern for both. This way might be cleaner? |
|
I am not sure what concrete change that would be? Where would the lock be put? Over what region? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we cache the registries, multiple threads can mutate the same pkginfo simultaneously
Should fix #4372.