Skip to content

Fix calloc argument order #59970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

Fix calloc argument order #59970

merged 1 commit into from
Oct 29, 2025
+2 −2

Conversation

@yuyichao
Copy link
Contributor

GCC 15 warns about these. These shouldn't behave any different AFAICT but just looks confusing (granted I never remember what's the correct order either...)

d-netto
d-netto approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@d-netto d-netto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We are calling calloc without checking whether it returns NULL in a number of places. We should probably use calloc_s in the future to output a more informative error message when allocation fails.

@LilithHafner LilithHafner assigned d-netto and unassigned LilithHafner Oct 27, 2025
@yuyichao yuyichao merged commit aed8996 into master Oct 29, 2025
6 of 8 checks passed
@yuyichao yuyichao deleted the yyc/codegen/calloc branch October 29, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-netto d-netto d-netto approved these changes

Assignees

@d-netto d-netto

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuyichao @d-netto @LilithHafner