BOLT: Fix libjulia* being rebulit after being instrumented #59978
+6
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zentrik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we instrument and optimize the libjulia* shared libraries we reset their mtime so make doesn't rebuild them. We were doing this by calling
stat -cto get the mtime then setting it using touch however,stat -creturns an epoch timestamp in seconds and I believe not using the full precision was causing make to be rebuild the.sos. Instead now we telltouchto reset to the timestamps in a copy of the original file (which should have the same timestamps by usingcp -a)Tested this fixed the issue I was seeing where they were being rebuilt.