Skip to content

Comments

Drop more > and >= methods, instead routing them through </<=#201

Open
lgoettgens wants to merge 1 commit intoJuliaMath:masterfrom
lgoettgens:lg/invalidations-geq
Open

Drop more > and >= methods, instead routing them through </<=#201
lgoettgens wants to merge 1 commit intoJuliaMath:masterfrom
lgoettgens:lg/invalidations-geq

Conversation

@lgoettgens
Copy link
Contributor

This reduces the number of invalidations of loading DecFP from 517 to 232 (with julia 1.12.5). In particular, the following invalidation trees get resolved:

 inserting >=(x::Dec128, y::Dec128) @ DecFP ~/code/julia/DecFP.jl/src/DecFP.jl:496 invalidated:
   backedges: 1: superseding >=(x, y) @ Base operators.jl:472 with MethodInstance for >=(::Any, ::Any) (36 children)

 inserting >(x::Dec128, y::Dec128) @ DecFP ~/code/julia/DecFP.jl/src/DecFP.jl:496 invalidated:
   backedges: 1: superseding >(x, y) @ Base operators.jl:425 with MethodInstance for >(::Real, ::Real) (5 children)
              2: superseding >(x, y) @ Base operators.jl:425 with MethodInstance for >(::Any, ::Any) (419 children)

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.12%. Comparing base (a572ebd) to head (63b6ff5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files           2        2           
  Lines         593      593           
=======================================
  Hits          570      570           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant