Add high-level API Scatter for splitting 1D array#816
Open
ykkan wants to merge 1 commit intoJuliaParallel:masterfrom
Open
Add high-level API Scatter for splitting 1D array#816ykkan wants to merge 1 commit intoJuliaParallel:masterfrom
Scatter for splitting 1D array#816ykkan wants to merge 1 commit intoJuliaParallel:masterfrom
Conversation
vchuravy
reviewed
Jun 23, 2024
Comment on lines
+188
to
+189
| arr_len = MPI.Bcast(arr_len, root, comm) | ||
| elm_t = MPI.bcast(elm_t, root, comm) |
Member
There was a problem hiding this comment.
Why is one of these Bcast and the other bcast?
Author
There was a problem hiding this comment.
If I remember correctly, elm_t is not a isbits type and can only be broadcasted with bcast. My idea was to use Bcast whenever possible, as its overhead should be less than bcast(?). Of course, using bcast for both elm_t and arr_len should work. I think my idea behind is rather a matter of style. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the idea of
Gather, a high-level APIScatterforScatter!is provided. With this API, users can easily scatter a 1D array without handlingVBufferorUBuffer.For example:
Output (
nprocs=3):