Allow CI to pass even if the processcoverage step fails#901
Merged
Conversation
giordano
reviewed
Apr 29, 2025
| - uses: julia-actions/julia-processcoverage@v1 | ||
| # Allow CI to pass even if the `processcoverage` step fails: | ||
| continue-on-error: true | ||
| - uses: codecov/codecov-action@v5 |
Member
Author
There was a problem hiding this comment.
IIRC, the default behavior for codecov-action is to not fail CI on a Codecov error: https://github.com/codecov/codecov-action/blob/ad3126e916f78f00edff4ed0317cf185271ccc2d/action.yml#L48-L51
So I don't think we need continue-on-error for the codecov-action step.
Member
There was a problem hiding this comment.
I'd prefer not to rely on defaults, but whatever.
DilumAluthge
commented
Apr 29, 2025
… relying on the default value)
DilumAluthge
force-pushed
the
dpa/process-coverage-continue-on-error
branch
from
abc61a4 to
222673b
Compare
giordano
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.